RFR: 8303951: Add asserts before record_method_not_compilable where possible [v4]

[Emanuel Peter]

> I went through all `C2` bailouts, and checked if they are justified to bail out of compilation silently. I added asserts everywhere. Those that were hit, I inspected by hand.
> 
> Some of them seem to be justified. There I added comments why they are justified. They are cases that we do not want to handle in `C2`, and that are rare enough so that it probably does not matter.
> 
> For the following bailouts I did not add an assert, because it may have revealed a bug:
> [JDK-8304328](https://bugs.openjdk.org/browse/JDK-8304328) C2 Bailout "failed spill-split-recycle sanity check" reveals hidden issue with RA
> 
> Note:
> [JDK-8303466](https://bugs.openjdk.org/browse/JDK-8303466) C2: COMPILE SKIPPED: malformed control flow - only one IfProj
> That bug bug was the reason for this RFE here. I added the assert for "malformed control flow". After this RFE here, that Bug will run into the assert on debug builds.
> 
> I ran `tier1-6` and stress testing. Now running `tier7-9`.
> 
> Filed a follow-up RFE to do the same for `BAILOUT` in `C1`: [JDK-8304532](https://bugs.openjdk.org/browse/JDK-8304532).

Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:

  remove some of my bad comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13038/files
  - new: https://git.openjdk.org/jdk/pull/13038/files/6e60f02e..9a40a1a9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13038&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13038&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/13038.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13038/head:pull/13038

PR: https://git.openjdk.org/jdk/pull/13038