RFR: 8304880: [PPC64] VerifyOops code in C1 doesn't work with ZGC

Martin Doerr mdoerr at openjdk.org
Fri Mar 24 16:38:53 UTC 2023


On Fri, 24 Mar 2023 16:11:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> So this `check_oop` happens too early after the load, right?

Correct, it is placed between the raw load and the load barrier.
 
> There are also `VerifyOops` blocks for stores in the same file, would you like to handle those as well? These oops should be okay with most GCs, but the point about the code size stands. Other platforms do not have the checks on those paths too, AFAICS.

The store cases are ok with all GCs because we only write valid oops into the heap. Stores seem to be a less frequent than loads. So, the impact on size is smaller. But we could discuss the removal. Other platforms don't have them.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13175#issuecomment-1483093585


More information about the hotspot-compiler-dev mailing list