RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

[Cesar Soares Lucas]

On Fri, 24 Mar 2023 19:53:52 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add support for SR'ing some inputs of merges used for field loads
>
> src/hotspot/share/opto/callnode.hpp line 614:
> 
>> 612:   int merge_pointer_idx(JVMState* jvms) const {
>> 613:     assert(jvms != nullptr, "JVMS reference is null.");
>> 614:     return jvms->scloff() + _merge_pointer_idx;
> 
> how about we also assert is_from_merge() here? 
> 
> Your comment above says that _merge_point_idx is a zero-based index of sfpt's input array. 
> here we use scloff-based. I think either is okay, but we need consistency.

I think adding assert is a good idea. I'll fix the comment. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1148148247