RFR: JDK-8302644: IGV: Apply filters per graph tab and not globally [v6]
Tobias Holenstein
tholenstein at openjdk.org
Mon Mar 27 07:53:24 UTC 2023
On Mon, 27 Mar 2023 07:10:05 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Tobias Holenstein has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - always select previous profile for new tabs
>> - .js ending for filters
>> - save order of filters
>
> src/utils/IdealGraphVisualizer/FilterWindow/src/main/java/com/sun/hotspot/igv/filterwindow/FilterTopComponent.java line 454:
>
>> 452:
>> 453: String after = (String) fo.getAttribute(AFTER_ID);
>> 454: System.out.println(displayName + " after " + after);
>
> Please remove.
done
> src/utils/IdealGraphVisualizer/FilterWindow/src/main/java/com/sun/hotspot/igv/filterwindow/FilterTopComponent.java line 632:
>
>> 630: allFiltersOrdered.sortBy(order);
>> 631:
>> 632: System.out.println("readExternal");
>
> Please remove.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12714#discussion_r1148916838
PR Review Comment: https://git.openjdk.org/jdk/pull/12714#discussion_r1148917069
More information about the hotspot-compiler-dev
mailing list