RFR: 8302738: IGV: refine 'Simplify graph' filter [v2]

[Roberto Castañeda Lozano]

On Mon, 20 Mar 2023 10:06:04 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - Increase the bold text line factor slightly
>>  - Add extra horizontal margin for long labels and let them overflow within the node
>>  - Select slots as well
>>  - Remove code that is commented out
>>  - Assert inputLabel is non-null
>
> src/utils/IdealGraphVisualizer/Filter/src/main/java/com/sun/hotspot/igv/filter/CombineFilter.java line 71:
> 
>> 69:                             }
>> 70:                         }
>> 71: 
> 
> I think `assert slot != null;` should be moved up here

Makes sense, but I did not change it because the surrounding code is essentially dead (no current filter has a "reversed" `CombineRule`) and I would not be able to test it. Since this code has not been executed for years, it is likely to be broken anyway.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12955#discussion_r1149132866