RFR: 8302738: IGV: refine 'Simplify graph' filter [v2]

[Roberto Castañeda Lozano]

On Mon, 20 Mar 2023 10:19:42 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - Increase the bold text line factor slightly
>>  - Add extra horizontal margin for long labels and let them overflow within the node
>>  - Select slots as well
>>  - Remove code that is commented out
>>  - Assert inputLabel is non-null
>
> src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/Figure.java line 343:
> 
>> 341:                     inputLabel = nodeTinyLabel;
>> 342:                 }
>> 343:                 if (inputLabel != null) {
> 
> according to my IDE inputLabel is here always non-null.

Replaced with an assertion.

> src/utils/IdealGraphVisualizer/Graph/src/main/java/com/sun/hotspot/igv/graph/InputSlot.java line 76:
> 
>> 74:         int gapAmount = (int)((getPosition() + 1)*gapRatio);
>> 75:         return new Point(gapAmount + Figure.getSlotsWidth(Figure.getAllBefore(getFigure().getInputSlots(), this)) + getWidth()/2, -Figure.SLOT_START);
>> 76:         //return new Point((getFigure().getWidth() / (getFigure().getInputSlots().size() * 2)) * (getPosition() * 2 + 1), -Figure.SLOT_START);
> 
> perhaps remove this old comment

Thanks, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12955#discussion_r1149143319
PR Review Comment: https://git.openjdk.org/jdk/pull/12955#discussion_r1149142813