RFR: 8302738: IGV: refine 'Simplify graph' filter [v2]

[Roberto Castañeda Lozano]

On Mon, 20 Mar 2023 11:49:52 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> src/utils/IdealGraphVisualizer/View/src/main/java/com/sun/hotspot/igv/view/DiagramScene.java line 218:
>> 
>>> 216:                     if (ids.contains(figure.getInputNode().getId())) {
>>> 217:                         selectedFigures.add(figure);
>>> 218:                     }
>> 
>> Suggestion:
>> 
>>                     }
>>                     for (Slot slot : figure.getSlots()) {
>>                         if (!Collections.disjoint(slot.getSource().getSourceNodesAsSet(), ids)) {
>>                             highlightedObjects.add(slot);
>>                         }
>>                     }
>> 
>> I am not sure what your intent was in adding the slots to the selected objects. If you wanted the slots to be selected globally in "link global node selection" mode, you need to add the following code to make it work
>
> Even if this was not you intention, I think selecting the slots globally is a useful feature.

Thanks for the suggestion! I added support for this now, however after considering the amount of work required to implement proper interaction with slots in a consistent manner, I lean towards excluding the partial implementation from this changeset and leaving it instead for future work, see my reply to @chhagedorn.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12955#discussion_r1149183957