RFR: JDK-8304684: Memory leak in DirectivesParser::set_option_flag [v2]

Justin King jcking at openjdk.org
Mon Mar 27 20:12:26 UTC 2023


On Fri, 24 Mar 2023 19:45:09 GMT, Justin King <jcking at openjdk.org> wrote:

>> `DirectiveSet::compilecommand_compatibility_init` makes things even more complicated, because it doesnt update `_modified` and it should probably be making a copy of the string provided via `CompilerOracle::has_option_value`. Ugh...
>
> Nevermind, it looks like `CompilerOracle::has_option_value` has static duration effectively. So I should be able to fix this.

Okay, think I was able to figure it out. Running GHA again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13125#discussion_r1149741203


More information about the hotspot-compiler-dev mailing list