RFR: 8302738: IGV: refine 'Simplify graph' filter [v3]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Tue Mar 28 17:12:31 UTC 2023
On Tue, 28 Mar 2023 17:01:22 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> The "Simplify graph" filter abstracts away details from the graph that are typically unnecessary for debugging or analyzing the represented program. This changeset decouples this filter into two:
>>
>> - "Simplify graph", which hides elements that are typically (but not always) unnecessary, and
>> - "Condense graph", which makes the graph more compact without loss of information.
>>
>> Together, these two filters reduce the average graph size by a factor of 1.6x (nodes) and 1.9x (edges):
>>
>> 
>>
>> Besides decoupling the "Simplify graph" filter, the changeset extends its functionality by:
>> - combining Bool and conversion nodes into their predecessors,
>> - inlining all Parm nodes except control into their successors (this removes lots of long edges),
>> - removing "top" inputs from call-like nodes,
>> - inlining more source nodes (such as MachTemp and ThreadLocal) into their successors,
>> - pretty-printing the labels of many inlined and combined nodes such as Bool comparisons or Catch projections (via a new filter that edits node properties), and
>> - using a sparse representation of nodes with empty inputs (e.g. call-like nodes after applying "Simplify graph").
>>
>> The sparse input representation shows dots between non-contiguous inputs, instead of horizontal space proportional to the number of empty inputs. This helps reducing node width, which is known to improve overall layout quality:
>>
>> 
>>
>> Note that the exact input indices can still be retrieved via the incoming edge's tooltips:
>>
>> 
>>
>> The control-flow graph view is also adapted to this representation:
>>
>> 
>>
>> #### Additional improvements
>>
>> Additionally, this changeset:
>> - ensures that the selected filter subset is applied in the order listed in the "Filter" window (this is necessary for combining effectively the "Simplify graph" and "Condense graph" filters, but is also generally desirable for simplicity and consistency),
>> - introduces a complementary filter "Show custom node info" (enabled by default) that extends the labels of call and exception-creation nodes with custom information,
>> - extends the search functionality so that combined and inlined nodes can also be searched on and selected, and
>> - defines and documents JavaScript helpers to simplify the new and existing available filters.
>>
>> Here is an example of the effect of the new "Show custom node info" filter:
>>
>> 
>>
>> ### Testing
>>
>> #### Functionality
>>
>> - Tested the functionality manually on a small selection of graphs.
>>
>> - Tested automatically that viewing thousands of graphs in the three views with different filter subsets enabled does not trigger any assertion failure (by instrumenting IGV to view graphs as they are loaded and running `java -Xcomp -XX:-TieredCompilation -XX:PrintIdealGraphLevel=4`).
>>
>> #### Performance
>>
>> Measured the combined filter application and view creation time for the sea-of-nodes view on a selection of 100 medium-sized graphs (200-500 nodes). On average, applying the new "Show custom node info" filter introduces a minimal overhead of around 1%, which motivates enabling it by default. Applying the "simplify graph" and "condense graph" on top actually gives a speedup of about 12%, since the additional filter application time is amortized by laying out and drawing fewer nodes. However, these filters are not enabled by default, since they cause a (minor) loss of information which is not desirable in every use case.
>>
>> The graph size reduction and performance results are [attached](https://github.com/openjdk/jdk/files/10934804/performance-evaluation.ods) (note that each time measurement in the sheet corresponds to the median of ten runs).
>
> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert "Select slots as well"
>
> This reverts commit 8256f0c20d7747cda691291c47841a9280d8c493.
>
> Revert "Fix figure selection"
>
> This reverts commit 71e73e89facfbb31614e4f1f3676c9e91a38e01a.
>
> Revert "Make slots searchable and selectable"
>
> This reverts commit 69cbec1f24ec5e941a5a72ab94b79117551d9560.
I just reverted the partial support for slot interaction, the behavior in this area should be now the same as in baseline IGV, please review. Will write an RFE with an initial implementation after this changeset is integrated.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12955#issuecomment-1487302841
More information about the hotspot-compiler-dev
mailing list