RFR: 8304681: compiler/sharedstubs/SharedStubToInterpTest.java fails after JDK-8304387 [v2]

Xiaolin Zheng xlinzheng at openjdk.org
Wed Mar 29 08:11:55 UTC 2023


> Please review this test fix for [JDK-8304387](https://bugs.openjdk.org/browse/JDK-8304387) after RFR.
> 
> Instead of specifying shared stubs' locations in this test, we could check if two or more relocations combined with each of them in this test, same as the other test `SharedTrampolineTest.java`. The counting logic is aligned with `SharedTrampolineTest.java`. Printing relocation stuff requires debug version vm, so this test is changed to debug only. Also some minor cleanups for the tests.
> 
> Apologies for the tier2 failure. I mainly focused on if there were new hs_errs when working on JDK-8304387. :-(
> 
> I am now confirming if the comment "Static stubs must be created at the end of the Stub section" could be removed, which needs a little extra time - though I think we can relax such limitations in `SharedStubToInterpTest.java`.
> -- Update on March 27th: comfirmed; please see the JBS issue for the discussion.
> 
> Tested x86_64, AArch64 and RISC-V for tests under `compiler/sharedstubs` folder, and now all passed (release, fastdebug).
> 
> Thanks,
> Xiaolin

Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:

  Aleksey's code style suggestions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13135/files
  - new: https://git.openjdk.org/jdk/pull/13135/files/3f343c2b..d5573ac3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13135&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13135&range=00-01

  Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/13135.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13135/head:pull/13135

PR: https://git.openjdk.org/jdk/pull/13135


More information about the hotspot-compiler-dev mailing list