RFR: 8302814: Delete unused CountLoopEnd instruct with CmpX [v6]

Vladimir Kozlov kvn at openjdk.org
Wed Mar 29 17:22:50 UTC 2023


On Wed, 29 Mar 2023 01:19:43 GMT, SUN Guoyun <duke at openjdk.org> wrote:

>> CountLoopEnd only for T_int, therefore the following instructs in riscv.ad are useless and should be deleted.
>> 
>> CountedLoopEnd cmp (CmpU op1 op2)
>> CountedLoopEnd cmp (CmpP op1 op2)
>> CountedLoopEnd cmp (CmpN op1 op2)
>> CountedLoopEnd cmp (CmpF op1 op2)
>> CountedLoopEnd cmp (CmpD op1 op2)
>> 
>> and CountedLoopEnd with CmpU on x86*.ad, aarch64.ad ar useless also.
>> 
>> Please help review it.
>> 
>> Thanks.
>
> SUN Guoyun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8302814
>  - 8302814: Delete unused CountLoopEnd instruct with CmpX
>  - 8302814: Delete unused CountLoopEnd instruct with CmpX
>  - 8302814: Delete unused CountLoopEnd instruct with CmpX
>  - Merge branch 'openjdk:master' into 8302814
>  - Merge branch 'openjdk:master' into 8302814
>  - 8302814: Delete unused CountLoopEnd instruct with CmpX

My testing (tier1-4, xcomp, stress) passed with latest version.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12648#issuecomment-1489000893


More information about the hotspot-compiler-dev mailing list