RFR: 8173709: Fix VerifyLoopOptimizations - step 1 - minimal infrastructure [v4]

[Emanuel Peter]

On Wed, 29 Mar 2023 17:13:42 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restrict VerifyLoopOptimizations to ASSERT / DEBUG_ONLY
>
> src/hotspot/share/opto/loopnode.cpp line 4862:
> 
>> 4860:       child_verify = children_verify.at(j);
>> 4861:     }
>> 4862:     if (child != nullptr && child_verify != nullptr && child->_head != child_verify->_head) {
> 
> May be have sanity assert before this line that we can't have both values equal to `nullptr`.

Will add it.

> src/hotspot/share/opto/loopnode.cpp line 4863:
> 
>> 4861:     }
>> 4862:     if (child != nullptr && child_verify != nullptr && child->_head != child_verify->_head) {
>> 4863:       assert(child->_head->_idx != child_verify->_head->_idx, "is implied");
> 
> Why you need this assert? It duplicate the check you already have.

Will remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13207#discussion_r1152788962
PR Review Comment: https://git.openjdk.org/jdk/pull/13207#discussion_r1152788866