RFR: 8305055: IR check fails on some aarch64 platforms

Emanuel Peter epeter at openjdk.org
Thu Mar 30 06:53:15 UTC 2023


On Thu, 30 Mar 2023 04:13:39 GMT, Fei Gao <fgao at openjdk.org> wrote:

> As @eme64 said in [1], [JDK-8298935](https://bugs.openjdk.org/browse/JDK-8298935) introduced some "collateral damage", disabling the vectorization of some conversions when `+AlignVector`. That affects IR checks of `TestVectorizeTypeConversion.java` and `ArrayTypeConvertTest.java` on some `aarch64` platforms like ThunderX and ThunderX2 [2].
> 
> This trivial patch is to allow IR check only when we have `-AlignVector`.
> 
> [1] https://github.com/openjdk/jdk/pull/12350#issuecomment-1470065706
> [2] https://github.com/openjdk/jdk/blob/7239150f8aff0e3dc07c5b27f6b7fb07237bfc55/src/hotspot/cpu/aarch64/vm_version_aarch64.cpp#L154

Otherwise looks good.

@fg1417 Thanks for doing this.
I guess this is only a temporary solution?
We should revert this change when we fix [JDK-8303827](https://bugs.openjdk.org/browse/JDK-8303827). I added a comment to that RFE.

@fg1417 Maybe rather than mentioning [JDK-8298935](https://bugs.openjdk.org/browse/JDK-8298935) in the test, you could mention that we can remove it after [JDK-8303827](https://bugs.openjdk.org/browse/JDK-8303827).

-------------

Marked as reviewed by epeter (Committer).

PR Review: https://git.openjdk.org/jdk/pull/13236#pullrequestreview-1364434750
PR Comment: https://git.openjdk.org/jdk/pull/13236#issuecomment-1489781605
PR Comment: https://git.openjdk.org/jdk/pull/13236#issuecomment-1489783462


More information about the hotspot-compiler-dev mailing list