RFR: 8305222: Change unique_ctrl_out_or_null to unique_ctrl_out in PhaseCFG::convert_NeverBranch_to_Goto

Thu Mar 30 07:29:28 UTC 2023

On Thu, 9 Mar 2023 21:08:45 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Replaced `unique_ctrl_out_or_null` with `unique_ctrl_out`, which asserts if it finds `nullptr`. This is better than running into a `nullptr`-dereference inside `get_block_for_node`.
>> 
>> This was found by a static code analyzer, so it is not clear that a `nullptr` dereference would ever happen. But let's still fix it.
>
> Good.

@vnkozlov @TobiHartmann Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12919#issuecomment-1489823321