RFR: JDK-8302644: IGV: Apply filters per graph tab and not globally

[Tobias Holenstein]

On Tue, 7 Mar 2023 12:37:06 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> I updated the PR. @robcasloz 
>> 
>>> However, as an IGV user I miss two things from the current behavior: persistence (the same filters are applied after restarting IGV)
>> 
>> I agree with this. Now global filters profiles are saved and reloaded at startup
>> 
>>> and the ability to apply the same filter configuration to all tabs in a simple manner.
>> 
>> Before my PR all filter profiles were global. And they still are except for the `--Local--` profile. I now added also a `--Global--` profile that is selected by default. 
>> 
>>> I would like to propose an alternative model that is almost a superset of what is proposed here and would preserve persistence and easy filter synchronization among tabs. By default, each tab has two filter profiles available, “local” and “global”.
>> 
>> I added that now.
>> 
>>> More profiles cannot be added or removed.
>> 
>> I would prefer to keep the option to define new profile (especially, now that they are saved and reloaded at startup)
>> 
>>> The local filter profile can be edited but is not persistent (i.e. it acts like the --Custom-- profile in this changeset).
>> 
>> That’s what we have now
>> 
>>> The global filter profile can be edited, is persistent, and the changes are propagated for all tabs where it is selected.
>> 
>> `--Global--` is like this
>> 
>>> The Link node selection globally button is generalized to Link node and filter selection globally. It is disabled by default, and clicking on it selects the global filter profile for all opened tabs.
>> 
>>  I prefer to keep the option to have a Tab with local and a Tab with global filters AND be able to link the selection.
>
>> I now added also a --Global-- profile that is selected by default.
> 
> Thanks for the changes, Toby. I can see the `--Global--` profile selected by default, however as soon as I open a graph it switches to `--Local--`. Is this intended?

Thanks @robcasloz , @chhagedorn and @TobiHartmann for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12714#issuecomment-1489879259