RFR: 8303147: [s390x] fast & slow debug builds are broken [v2]

[Lutz Schmidt]

On Fri, 17 Mar 2023 08:37:28 GMT, SUN Guoyun <duke at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use constant instead of enum
>
> I don't think the current modification is reasonable, why don't you modify `emit_typecheck_helper`?
> Maybe we can also @dean-long  has to say about this.

@sunny868 @dean-long You are right. The first approach was a band-aid at best. With more knowledge, it turns out the assert condition is incorrect. You have to consider a potentially non-zero FrameMap::first_available_sp_in_frame(). 

I expect @offamitkumar will come up with a suitable fix real soon.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12825#issuecomment-1491772237