RFR: 8304948: [vectorapi] C2 crashes when expanding VectorBox [v3]

[Quan Anh Mai]

On Thu, 4 May 2023 01:19:04 GMT, Eric Liu <eliu at openjdk.org> wrote:

>> src/hotspot/share/opto/vector.cpp line 345:
>> 
>>> 343:                                               box_type, vect_type, visited);
>>> 344:       if (!new_box->is_Phi()) {
>>> 345:         C->initial_gvn()->hash_delete(vbox);
>> 
>> May I ask why is this needed? Thanks.
>
>> May I ask why is this needed? Thanks.
> 
> It is a constraint that nodes must be removed from hash table before modifying their inputs.  https://github.com/openjdk/jdk/blob/f4630cdc6f49812d147b9ba8a4ea4009968f0db2/src/hotspot/share/opto/node.hpp#L434

Ah yes silly me, thanks a lot for your answers, I have no more questions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13489#discussion_r1184515136