RFR: 8307527: MacOS Zero builds fail with undefined FFI_GO_CLOSURES after JDK-8304265 [v2]

Aleksey Shipilev shade at openjdk.org
Mon May 8 10:18:35 UTC 2023


> See the bug. Actually, I am not sure why JDK-8304265 changed the `#ifndef FFI_GO_CLOSURES` to `#ifdef _APPLE_`. That seems too intrusive if `FFI_GO_CLOSURES` *is* enabled. So I rewrote the block to something more safe.
> 
> Additional testing:
>  - [x] macos-aarch64-zero-fastdebug `make images` passes

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  Use a build system fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13827/files
  - new: https://git.openjdk.org/jdk/pull/13827/files/30029824..72f978ab

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13827&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13827&range=00-01

  Stats: 30 lines in 3 files changed: 20 ins; 10 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/13827.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13827/head:pull/13827

PR: https://git.openjdk.org/jdk/pull/13827


More information about the hotspot-compiler-dev mailing list