RFR: 8307651: RISC-V: Correct format typo for stringL_indexof_char instruction [v2]
Feilong Jiang
fjiang at openjdk.org
Tue May 9 09:08:26 UTC 2023
> Hi.
>
> Can I have reviews for this trivial patch that fixes a typo in the format of `stringL_indexof_char` instruction? It should be `StringLatin1` instead of `StringUTF16` for `StrIntrinsicNode::L`.
>
>
> instruct stringL_indexof_char(iRegP_R11 str1, iRegI_R12 cnt1, iRegI_R13 ch,
> iRegI_R10 result, iRegINoSp tmp1, iRegINoSp tmp2,
> iRegINoSp tmp3, iRegINoSp tmp4, rFlagsReg cr)
> %{
> match(Set result (StrIndexOfChar (Binary str1 cnt1) ch));
> predicate(!UseRVV && (((StrIndexOfCharNode*)n)->encoding() == StrIntrinsicNode::L));
> effect(USE_KILL str1, USE_KILL cnt1, USE_KILL ch, TEMP_DEF result,
> TEMP tmp1, TEMP tmp2, TEMP tmp3, TEMP tmp4, KILL cr);
>
> format %{ "StringUTF16 IndexOf char[] $str1,$cnt1,$ch -> $result" %} ====> Should be StringLatin1 here.
> ins_encode %{
> __ string_indexof_char($str1$$Register, $cnt1$$Register, $ch$$Register,
> $result$$Register, $tmp1$$Register, $tmp2$$Register,
> $tmp3$$Register, $tmp4$$Register, true /* isL */);
> %}
> ins_pipe(pipe_class_memory);
> %}
Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision:
add spaces
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13881/files
- new: https://git.openjdk.org/jdk/pull/13881/files/3f386f95..fab8b5ae
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13881&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13881&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/13881.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13881/head:pull/13881
PR: https://git.openjdk.org/jdk/pull/13881
More information about the hotspot-compiler-dev
mailing list