RFR: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712

Coleen Phillimore coleenp at openjdk.org
Thu May 11 12:36:43 UTC 2023


On Tue, 9 May 2023 13:02:45 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

> - The `finalize()` method is replaced with `cleanup()`. 
> - A new constructor is added to register the cleanup method.
> - A static `Cleaner` is defined to have only one cleaner thread for all the 15000 instances. Otherwise, we get an `OutOfMemoryException` on cleaner thread creation.

I think this looks good, and still tests what the original test failure was.  Unless the bug was with the _return_register_finalizer bytecode, but I don't think that's the case.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13886#pullrequestreview-1422508567


More information about the hotspot-compiler-dev mailing list