RFR: 8307609: RISC-V: Added support for Extract, Compress, Expand and other nodes for Vector API [v4]

Dingli Zhang dzhang at openjdk.org
Tue May 16 07:35:46 UTC 2023


> Hi all,
> 
> We have added support for Extract, Compress, Expand and other nodes for Vector
> API. It was implemented by referring to RVV v1.0 [1]. Please take a look and
> have some reviews. Thanks a lot.
> 
> In this PR, we will support these new nodes:
> 
> CompressM/CompressV/ExpandV
> LoadVectorGather/StoreVectorScatter/LoadVectorGatherMasked/StoreVectorScatterMasked
> Extract
> VectorLongToMask/VectorMaskToLong
> PopulateIndex
> VectorLongToMask/VectorMaskToLong
> VectorMaskTrueCount/VectorMaskFirstTrue
> VectorInsert
> 
> 
> At the same time, we refactored methods such as
> `match_rule_supported_vector_mask`. All implemented vector nodes support mask
> operations by default now, so we also added mask nodes for all implemented
> nodes. 
> 
> By the way, we will implement the VectorTest node in the next PR.
> 
> We can use the tests under `test/jdk/jdk/incubator/vector` to print the 
> compilation log for most of the new nodes. And we can use the following 
> command to print the compilation log of a jtreg test case:
> 
> 
> $ jtreg \
> -v:default \
> -concurrency:16 -timeout:50 \
> -javaoption:-XX:+UnlockExperimentalVMOptions \
> -javaoption:-XX:+UseRVV \
> -javaoption:-XX:+PrintOptoAssembly \
> -javaoption:-XX:LogFile=log_name.log \
> -jdk:build/linux-riscv64-server-fastdebug/jdk \
> -compilejdk:build/linux-x86_64-server-release/images/jdk \
> <test-case>
> 
> 
> 
> 
> ### CompressM/CompressV/ExpandV
> 
> There is no inverse vdecompress provided in RVV, as this operation can be
> readily synthesized using iota and a masked vrgather in `ExpandV`.
> 
> We can use `test/jdk/jdk/incubator/vector/Float256VectorTests.java` to emit
> these nodes and the compilation log is as follows:
> 
> 
> ## CompressM
> 2aa     addi  R29, R10, #16	# ptr, #@addP_reg_imm
> 2ae     mcompress V0, V30	# KILL R30
> 2c2     vstoremask V2, V0
> 2ce     storeV [R7], V2	# vector (rvv)
> 2d6     bgeu  R29, R28, B47	#@cmpP_branch  P=0.000100 C=-1.000000
> 
> ## CompressV
> 0ee     addi  R29, R10, #16	# ptr, #@addP_reg_imm
> 0f2     vcompress V1, V2, V0
> 0fe     storeV [R7], V1	# vector (rvv)
> 106     bgeu  R29, R28, B10	#@cmpP_branch  P=0.000100 C=-1.000000
> 
> ## ExpandV
> 0ee     addi  R29, R10, #16	# ptr, #@addP_reg_imm
> 0f2     vexpand V3, V2, V0
> 102     storeV [R7], V3	# vector (rvv)
> 10a     bgeu  R29, R28, B10	#@cmpP_branch  P=0.000100 C=-1.000000
> 
> 
> 
> 
> ### LoadVectorGather/StoreVectorScatter/LoadVectorGatherMasked/StoreVectorScatterMasked
> 
> We use the vsoxei32_v instruction regardless of what sew is set to. The
> indexMap in fromArr...

Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:

  Change some iRegI to iRegIorL2I and small refactoring of minmax_fp_masked_v

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13862/files
  - new: https://git.openjdk.org/jdk/pull/13862/files/c4351ee1..486ebe7f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13862&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13862&range=02-03

  Stats: 63 lines in 3 files changed: 14 ins; 12 del; 37 mod
  Patch: https://git.openjdk.org/jdk/pull/13862.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13862/head:pull/13862

PR: https://git.openjdk.org/jdk/pull/13862


More information about the hotspot-compiler-dev mailing list