RFR: 8305634: Renaming predicates, simple cleanups, and adding summary about current predicates [v4]

[Christian Hagedorn]

On Mon, 15 May 2023 08:11:34 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/opto/loopPredicate.cpp
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/share/opto/loopPredicate.cpp line 150:
> 
>> 148:  *                                                   The Initialized Assertion Predicates are always true because we will
>> 149:  *                                                   never enter the main loop because of the changed pre- and main-loop
>> 150:  *                                                   exit conditions.
> 
> This does still not quite sound right. We will never enter the main loop? Sounds like the main-loop is ueseless in all cases. Suggestion:
> 
> 
> The Initialized Assertion Predicates are always true: they are true when we enter the main loop
> (because we adjusted the pre-loop exit condition), they are true in the last iteration (because we
> adjust the main-loop exit condition), and they are true in all iterations in the middle by implication.

Thanks for the suggestion, I've pushed an update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13864#discussion_r1195158362