RFR: 8300081: Replace NULL with nullptr in share/asm/

[Johan Sjölen]

On Tue, 16 May 2023 12:10:34 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/asm. Unfortunately the script that does the change isn't perfect, and so we need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

Only 3 comment issues

src/hotspot/share/asm/codeBuffer.cpp line 712:

> 710:     buf_limit = (address)dest->relocation_end() - buf;
> 711:   }
> 712:   // if dest == null, this is just the sizing pass

is null

src/hotspot/share/asm/codeBuffer.cpp line 880:

> 878:   // Resizing must be allowed
> 879:   {
> 880:     if (blob() == nullptr)  return;  // caller must check for blob == null

"check whether blob is null"

src/hotspot/share/asm/codeBuffer.cpp line 971:

> 969: void CodeBuffer::verify_section_allocation() {
> 970:   address tstart = _total_start;
> 971:   if (tstart == badAddress)  return;  // smashed by set_blob(null)

nullptr

-------------

PR Review: https://git.openjdk.org/jdk/pull/14010#pullrequestreview-1428434793
PR Review Comment: https://git.openjdk.org/jdk/pull/14010#discussion_r1195070386
PR Review Comment: https://git.openjdk.org/jdk/pull/14010#discussion_r1195070755
PR Review Comment: https://git.openjdk.org/jdk/pull/14010#discussion_r1195070958