RFR: 8307609: RISC-V: Added support for Extract, Compress, Expand and other nodes for Vector API [v6]

[Dingli Zhang]

On Wed, 17 May 2023 02:08:58 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove trailing whitespace
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1647:
> 
>> 1645: void C2_MacroAssembler::minmax_fp_masked_v(VectorRegister dst, VectorRegister src1, VectorRegister src2,
>> 1646:                                            VectorRegister vmask, int vector_length, VectorRegister tmp1,
>> 1647:                                            VectorRegister tmp2, bool is_double, bool is_min) {
> 
> Suggestion: make `vector_length` the last parameter so that it will be more consistent in style with friend `C2_MacroAssembler::minmax_fp_v`

Fixed.

> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1683:
> 
>> 1681: 
>> 1682:   is_min ? vfredmin_vs(tmp1, src2, tmp2, vm)
>> 1683:          : vfredmax_vs(tmp1, src2, tmp2, vm);
> 
> Suggestion: put the result of reduction in `dst` with `vfmv_f_s(dst, tmp1)` here and save the `j(L_done_check)` at line 1695.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13862#discussion_r1195980293
PR Review Comment: https://git.openjdk.org/jdk/pull/13862#discussion_r1195980433