RFR: 8305635: Replace Parse Predicate IfNode with new ParsePredicateNode and route predicate queries through dedicated classes [v2]

[Christian Hagedorn]

On Wed, 17 May 2023 10:48:24 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tobias' review
>
> src/hotspot/share/opto/cfgnode.hpp line 462:
> 
>> 460: // More information about predicates can be found at loopPredicate.cpp.
>> 461: class ParsePredicateNode : public IfNode {
>> 462:   Deoptimization::DeoptReason _deopt_reason;
> 
> Don't we need to override `Node::hash()` and `Node::cmp()` here to account for the `_deopt_reason` field?

Since it is a CFG node, the hash should always be different due to a different control input. If two `If` nodes have the same control input after an optimization, the graph is broken.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14017#discussion_r1196397089