RFR: 8051725: Improve expansion of Conv2B nodes in the middle-end [v6]

[Jasmine Karthikeyan]

On Fri, 28 Apr 2023 05:48:39 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Jasmine Karthikeyan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge branch 'master' into conv2b-x86-lowering
>>  - Whitespace tweak
>>  - Make transform conditional
>>  - Remove Conv2B from backend as it's macro expanded now
>>  - Re-work transform to happen in macro expansion
>>  - Fix whitespace and add bug tag to IR test
>>  - Merge branch 'master' into conv2b-x86-lowering
>>  - Merge branch 'master' into conv2b-x86-lowering
>>  - Merge branch 'master' into conv2b-x86-lowering
>>  - Merge branch 'master' into conv2b-x86-lowering
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/bad6aa68...295b9a67
>
> src/hotspot/share/opto/cfgnode.cpp line 1576:
> 
>> 1574:   Node *n = new Conv2BNode(cmp->in(1));
>> 1575:   if( flipped )
>> 1576:   n = new XorINode( phase->transform(n), phase->intcon(1) );
> 
> This lives under the `if (flipped)`, maybe move into a block for more clarity.

Fixed, thanks.

> src/hotspot/share/opto/macro.cpp line 44:
> 
>> 42: #include "opto/macro.hpp"
>> 43: #include "opto/memnode.hpp"
>> 44: #include "opto/movenode.hpp"
> 
> Unnecessary change?

Oops, I forgot to remove the include from the old macro expansion logic. Thanks for the catch!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13345#discussion_r1197336184
PR Review Comment: https://git.openjdk.org/jdk/pull/13345#discussion_r1197336090