RFR: 8051725: Improve expansion of Conv2B nodes in the middle-end [v7]
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Thu May 18 04:17:48 UTC 2023
> Hi, I've created optimizations for the expansion of `Conv2B` nodes, especially when followed immediately by an xor of 1. This pattern is fairly common, and can arise from both [cmov idealization](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/movenode.cpp#L241) and [diamond-phi optimization](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/cfgnode.cpp#L1571). This change replaces `Conv2B` nodes in the middle-end during post loop opts IGVN with conditional moves on supported platforms (x86_64, aarch64, arm32), allowing the bit flip with `xor` to be subsumed with an inversion of the comparison instead. This change also reduces the overhead of the matcher in the backends, as fewer rules need to be traversed in order to match an ideal node. Performance results from my (Zen 2) machine:
>
>
> Baseline Patch Improvement
> Benchmark Mode Cnt Score Error Units Score Error Units
> Conv2BRules.testEquals0 avgt 10 47.566 ± 0.346 ns/op / 34.130 ± 0.177 ns/op + 28.2%
> Conv2BRules.testNotEquals0 avgt 10 37.167 ± 0.211 ns/op / 34.185 ± 0.258 ns/op + 8.0%
> Conv2BRules.testEquals1 avgt 10 35.059 ± 0.280 ns/op / 34.847 ± 0.160 ns/op (unchanged)
> Conv2BRules.testEqualsNull avgt 10 56.768 ± 2.600 ns/op / 34.330 ± 0.625 ns/op + 39.5%
> Conv2BRules.testNotEqualsNull avgt 10 47.447 ± 1.193 ns/op / 34.142 ± 0.303 ns/op + 28.0%
>
> Reviews would be greatly appreciated!
>
> Testing: tier1-2 on linux x64, GHA
Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
Changes from code review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13345/files
- new: https://git.openjdk.org/jdk/pull/13345/files/295b9a67..69e914a5
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13345&range=06
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13345&range=05-06
Stats: 23 lines in 5 files changed: 8 ins; 2 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/13345.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13345/head:pull/13345
PR: https://git.openjdk.org/jdk/pull/13345
More information about the hotspot-compiler-dev
mailing list