RFR: 8302652: [SuperWord] Reduction should happen after loop, when possible [v9]
Emanuel Peter
epeter at openjdk.org
Mon May 22 06:52:58 UTC 2023
On Fri, 19 May 2023 15:59:08 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Is it not better to have `VectorNode::scalar_opcode`? It is more general - maybe it is useful in the future.
>
>> Is it not better to have `VectorNode::scalar_opcode`? It is more general - maybe it is useful in the future.
>
> Not a blocker, but we intend to get a scalar opcode for ReductionNode, we have different factory method for Vector/Reduction Nodes, you can keep it for now
>
> Best Regards,
> Jatin
@jatin-bhateja I see your point. On the other hand, we would have quite some code duplication handling all the BasicType cases for every operation. I'll leave it the way I have it now, and we can still reconsider it if we want to in the future.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13056#discussion_r1200037772
More information about the hotspot-compiler-dev
mailing list