RFR: 8051725: Improve expansion of Conv2B nodes in the middle-end [v7]

Tue May 23 07:09:42 UTC 2023

On Thu, 18 May 2023 14:36:42 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/addnode.cpp line 892:
>> 
>>> 890:   // Propagate xor through constant cmoves. This pattern can occur after expansion of Conv2B nodes.
>>> 891:   if (in1->Opcode() == Op_CMoveI && in2->is_Con()) {
>>> 892:     if (in1->in(2)->is_Con() && in1->in(3)->is_Con()) {
>> 
>> `CMoveNode::IfTrue` and `CMoveNode::IfFalse` instead of 3 and 2.
>
> `CMoveNode::Condition` instead of `in1->in(1)` below, too. You need to check for the node actually being a `BoolNode` in case a constant-condition `CMove` has not been folded yet.

Fixed, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13345#discussion_r1201643759