RFR: 8308444: LoadStoreNode::result_not_used() is too conservative

[Tobias Hartmann]

On Fri, 19 May 2023 16:19:42 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> This patch improves the implementation of `LoadStoreNode::result_not_used()` to be less conservative and verifies that the preferable node is matched for `getAndAdd`. Please kindly review, thanks a lot.

I'm seeing failures with `compiler/unsafe/JdkInternalMiscUnsafeAccessTestLong.java` and `JdkInternalMiscUnsafeAccessTestInt.java`:


test compiler.unsafe.JdkInternalMiscUnsafeAccessTestLong.testArray(): failure
java.lang.AssertionError: getAndAdd long expected [81985529216486895] but found [33520196056]
	at org.testng.Assert.fail(Assert.java:99)
	at org.testng.Assert.failNotEquals(Assert.java:1037)
	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
	at org.testng.Assert.assertEquals(Assert.java:122)
	at org.testng.Assert.assertEquals(Assert.java:797)
	at compiler.unsafe.JdkInternalMiscUnsafeAccessTestLong.testAccess(JdkInternalMiscUnsafeAccessTestLong.java:361)
	at compiler.unsafe.JdkInternalMiscUnsafeAccessTestLong.testArray(JdkInternalMiscUnsafeAccessTestLong.java:130)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14061#issuecomment-1559018427