RFR: 8306706: Support out-of-line code generation for MachNodes [v4]
Tobias Hartmann
thartmann at openjdk.org
Tue May 23 15:13:03 UTC 2023
On Thu, 18 May 2023 14:15:22 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Hi,
>>
>> This patch adds supports for MachNodes to emit an out-of-line piece of code in the stub section of the compiled method. This allows the separation of the uncommon path from the common one, which speeds up the common path a little bit and increases compiled code density. Please take a look and leave reviews.
>>
>> Thanks a lot.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>
> whitespace
Nice! The new version looks good to me.
src/hotspot/share/opto/c2_CodeStubs.hpp line 116:
> 114:
> 115: template <class... Ts>
> 116: class C2GeneralStub : public C2CodeStub {
A comment describing the purpose of this class would be good.
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13602#pullrequestreview-1439128798
PR Review Comment: https://git.openjdk.org/jdk/pull/13602#discussion_r1201897039
More information about the hotspot-compiler-dev
mailing list