RFR: 8300865: C2: product reduction in ProdRed_Double is not vectorized [v3]

Sandhya Viswanathan sviswanathan at openjdk.org
Tue May 23 22:35:04 UTC 2023


> This PR fixes the problem with double reduction on x86_64. 
> 
> In the test compiler.loopopts.superword.ProdRed_Double, the product reduction loop in prodReductionImplement() was not getting vectorized when run as follows:
> jtreg -XX:CompileCommand=PrintAssembly,compiler.loopopts.superword.ProdRed_Double::prodReductionImplement compiler/loopopts/superword/ProdRed_Double.java
> The print assembly generated in the pid-xxx.log output in JTwork/scratch directory was not showing any vector_reduction_double node.
> 
> This was happening as the ReductionNode::implemented was passed a vector size of one element. For the vector reduction implemented we need to check with at least vector size of two elements.
> 
> With this PR the vector_reduction_double node is generated.
> 
> Please review.
> 
> Best Regards,
> Sandhya

Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision:

  change to superword_max_vector_size

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14065/files
  - new: https://git.openjdk.org/jdk/pull/14065/files/d0acd1e6..ba3b5dfa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14065&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14065&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14065.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14065/head:pull/14065

PR: https://git.openjdk.org/jdk/pull/14065


More information about the hotspot-compiler-dev mailing list