RFR: 8306302: C2 Superword fix: use VectorMaskCmp and VectorBlend instead of CMoveVF/D

[Emanuel Peter]

On Wed, 24 May 2023 05:00:39 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>>> @fg1417 Since I'm basically implementing your suggestion: do you agree with this fix?
>> 
>> Hi @eme64 , nice rewrite!
>> 
>> BTW, have you tested your patch with `-XX:+UseCMoveUnconditionally` and `-XX:+UseVectorCmov` for all jtreg? Thanks.
>
>> Thanks @fg1417 for the review!
>> 
>> Yes, the testing passes up to at least tier5 and stress testing. With and without `-XX:+UseCMoveUnconditionally` and `-XX:+UseVectorCmov`
>> 
>> Yes, I hope that someone from intel / x86 specialists can review this too :) These are candidates: @jatin-bhateja @sviswa7 @merykitty
> 
> Your patch looks good to me.  
> 
> Patch testing with UseSSE=2 shows failure in following tests, failure is unrelated to your changes, we need to add a strict feature based check in test tag  * @requires os.simpleArch == "x64" & (vm.cpu.features ~= ".*avx.*") or use applyIfCPUFeature
> 
> make test TEST="test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxReductions.java" CONF=linux-x86_64-server-fastdebug JTREG="RETAIN=all;JOBS=8;TIMEOUT_FACTOR=8;JAVA_OPTIONS=-XX:UseSSE=2"

@jatin-bhateja I could reproduce it on master, so it is indeed unrelated.
Filed the bug https://bugs.openjdk.org/browse/JDK-8308746

Thanks @jatin-bhateja @fg1417 thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13493#issuecomment-1560556252