RFR: 8299974: Replace NULL with nullptr in share/adlc/
Johan Sjölen
jsjolen at openjdk.org
Wed May 24 18:01:10 UTC 2023
Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/adlc. Unfortunately the script that does the change isn't perfect, and so we need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
Here are some typical things to look out for:
1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
An example of this:
```c++
// This function returns null
void* ret_null();
// This function returns true if *x == nullptr
bool is_nullptr(void** x);
Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
Thanks!
-------------
Commit messages:
- Merge remote-tracking branch 'origin/master' into JDK-8299974
- Last one?
- Anotehr
- Missing fail
- Fixes
- Replace NULL with nullptr in share/adlc/
Changes: https://git.openjdk.org/jdk/pull/14008/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14008&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8299974
Stats: 1265 lines in 19 files changed: 0 ins; 0 del; 1265 mod
Patch: https://git.openjdk.org/jdk/pull/14008.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14008/head:pull/14008
PR: https://git.openjdk.org/jdk/pull/14008
More information about the hotspot-compiler-dev
mailing list