RFR: 8308656: RISC-V: vstring_compare doesnt manifest usage of all vector registers [v2]

Yanhong Zhu yzhu at openjdk.org
Thu May 25 01:22:56 UTC 2023


On Wed, 24 May 2023 15:37:07 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Please review this fix. 
>> vstring_compare instrinsic ( from c2_MacroAssembler_riscv.cpp ) uses vector registers v6 and v7 ( https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp#L1482 , vstr1 == v4, lmul=4) , but doesn't manifest their usage in riscv_v.ad file.
>> This fix resolves this situation.
>> No noticable difference one might see in generated code for now.
>> 
>> Testing: build testing only.
>
> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert part of the fix

Looks good.

-------------

Marked as reviewed by yzhu (Author).

PR Review: https://git.openjdk.org/jdk/pull/14102#pullrequestreview-1442945945


More information about the hotspot-compiler-dev mailing list