Integrated: 8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Thu May 25 11:10:05 UTC 2023
On Thu, 25 May 2023 07:04:54 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
> `TestFpMinMaxReductions.java` requires `UseAVX > 0` to enforce that floating-point min/max computations are matched by specialized implementations in x64 (see [x86.ad](https://github.com/openjdk/jdk/blob/2a18e537d60c88c015bea738764eef2ca610abf1/src/hotspot/cpu/x86/x86.ad#L1539)). This changeset guards the test file with an `avx.*` CPU feature instead, which is more robust because it reflects the final AVX configuration after all flags are processed (including flags such as `UseSSE` that might affect the final AVX configuration).
>
> #### Testing
>
> - `TestFpMinMaxReductions.java` in tier1-5 (windows-x64, linux-x64, and macosx-x64).
> - `TestFpMinMaxReductions.java` with all possible combinations of `UseAVX` and `UseSSE`.
This pull request has now been integrated.
Changeset: 5a0a238f
Author: Roberto Castañeda Lozano <rcastanedalo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/5a0a238f67ae2a7757611881c5c713149cefe3c0
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8308746: C2 IR test failures for TestFpMinMaxReductions.java with SSE2
Co-authored-by: Jatin Bhateja <jbhateja at openjdk.org>
Reviewed-by: chagedorn, thartmann
-------------
PR: https://git.openjdk.org/jdk/pull/14141
More information about the hotspot-compiler-dev
mailing list