RFR: 8299974: Replace NULL with nullptr in share/adlc/ [v3]

Johan Sjölen jsjolen at openjdk.org
Thu May 25 17:18:23 UTC 2023


> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/adlc. Unfortunately the script that does the change isn't perfect, and so we need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:

 - One more!
 - Fix the rest of the style issues

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14008/files
  - new: https://git.openjdk.org/jdk/pull/14008/files/393d84f4..39cdb84f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14008&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14008&range=01-02

  Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/14008.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14008/head:pull/14008

PR: https://git.openjdk.org/jdk/pull/14008


More information about the hotspot-compiler-dev mailing list