RFR: 8308339: AArch64: Remove extra `UseSVE` Predicate in ad file

Fei Gao fgao at openjdk.org
Wed May 31 04:16:06 UTC 2023


On Tue, 30 May 2023 08:43:08 GMT, Andrew Haley <aph at openjdk.org> wrote:

> How about
> 
> ```
>   // This predicate is unneeded because only SVE has pRegs.
>   // predicate(UseSVE > 0);
> ```
> 
> I still don't like it much, but at least it's clear.

Hi @theRealAph, thanks for your kind suggestion. I agree on you said. Compared with current simple rules, the changed rules may be not easy to follow. Since code size is not a big problem now, maintaining the status quo seems better.

I'll close the PR. Thanks again for your review!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14112#discussion_r1211066892


More information about the hotspot-compiler-dev mailing list