RFR: 8302673: [SuperWord] MaxReduction and MinReduction should vectorize for int [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Wed May 31 07:16:57 UTC 2023


On Wed, 17 May 2023 13:25:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Add a comment that explains that for `top` we will bail out - for that we can check `nullptr`.
>> In the other cases, we know that `n == AddI(x, int_con)`.
>
> You could also consider having a custom "pair" class, so that the "second-output" is more explicit. But maybe just more useful / explicit variable naming would do the trick. Maybe like `add_var` and `add_con`?

Thanks, I went with the tuple return option as suggested and also simplified the semantics of the function. Hope it is clearer now!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13924#discussion_r1211195949


More information about the hotspot-compiler-dev mailing list