RFR: 8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong values with Graal
David Leopoldseder
davleopo at openjdk.org
Wed May 31 09:06:18 UTC 2023
This PR fixes the UnsafeGetStableArrayElement test when run with the Graal compiler.
In the past this test also failed with graal because it was checking for c1/c2 semantics.
JDK-8264135 introduced changes to the UnsafeGetStableArrayElement test to account for the scenario when the test is run with the Graal compiler. If Graal is used it will assert that constants are folded by asserting matching instead of mismatch.
However, we had changes in Graal since then, since JDK-8275645 Graal no longer constant folds unaligned reads.
This lets the test fail again for the unaligned cases because it asserts graal folds them.
The fix is to actually assert mismatch on unaligned accesses.
-------------
Commit messages:
- 8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong
Changes: https://git.openjdk.org/jdk/pull/14242/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14242&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8309104
Stats: 13 lines in 1 file changed: 0 ins; 0 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/14242.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14242/head:pull/14242
PR: https://git.openjdk.org/jdk/pull/14242
More information about the hotspot-compiler-dev
mailing list