RFR: 8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong values with Graal
Doug Simon
dnsimon at openjdk.org
Wed May 31 12:15:55 UTC 2023
On Wed, 31 May 2023 08:46:19 GMT, David Leopoldseder <davleopo at openjdk.org> wrote:
> This PR fixes the UnsafeGetStableArrayElement test when run with the Graal compiler.
>
> In the past this test also failed with graal because it was checking for c1/c2 semantics.
> JDK-8264135 introduced changes to the UnsafeGetStableArrayElement test to account for the scenario when the test is run with the Graal compiler. If Graal is used it will assert that constants are folded by asserting matching instead of mismatch.
>
> However, we had changes in Graal since then, since JDK-8275645 Graal no longer constant folds unaligned reads.
> This lets the test fail again for the unaligned cases because it asserts graal folds them.
>
> The fix is to actually assert mismatch on unaligned accesses.
Marked as reviewed by dnsimon (Committer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/14242#pullrequestreview-1453043470
More information about the hotspot-compiler-dev
mailing list