RFR: 8303451: Synchronization entry in C2 debug info is misleading [v2]
Tobias Hartmann
thartmann at openjdk.org
Wed May 31 13:19:00 UTC 2023
On Sat, 27 May 2023 16:34:15 GMT, Daohan Qu <duke at openjdk.org> wrote:
>> This should fix [JDK-8303451](https://bugs.openjdk.org/browse/JDK-8303451).
>>
>> It is a trivial patch that fixes a misleading code comment at method entry printed by `-XX:+PrintAssembly`.
>>
>> For exmple,
>>
>> 0x0000ffffa409da88: stp x29, x30, [sp, #16] ;*synchronization entry
>>
>> will become
>>
>> 0x0000ffffa409da88: stp x29, x30, [sp, #16] ;* invocation entry (also synchronization entry if synchronized)
>
> Daohan Qu has updated the pull request incrementally with one additional commit since the last revision:
>
> Update output again
Couldn't we detect if the method is synchronized and adjust the comment accordingly?
-------------
PR Review: https://git.openjdk.org/jdk/pull/14192#pullrequestreview-1453192284
More information about the hotspot-compiler-dev
mailing list