RFR: 8309104: [JVMCI] compiler/unsafe/UnsafeGetStableArrayElement test asserts wrong values with Graal

David Leopoldseder davleopo at openjdk.org
Wed May 31 16:59:55 UTC 2023


On Wed, 31 May 2023 16:11:12 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/unsafe/UnsafeGetStableArrayElement.java line 204:
>> 
>>> 202: 
>>> 203:         // Trigger compilation, give (jar) graal enough time to warmup.
>>> 204:         for (int i = 0; i < 20_000 * 500; i++) {
>> 
>> The number of iterations seems rather excessive. Is it really needed since we run with `-Xbatch`?
>
> Good point. David, if this test passes on libgraal then there's no need to increase the test time (I assume that with `-Xbatch`, the `* 500` does noticeably increase the test time).

yeah, I used it for local testing. Ill remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14242#discussion_r1212028885


More information about the hotspot-compiler-dev mailing list