Integrated: 8318683: compiler/c2/irTests/TestPhiDuplicatedConversion.java "Failed IR Rules (2) of Methods (2)"

Jasmine Karthikeyan jkarthikeyan at openjdk.org
Wed Nov 1 06:16:13 UTC 2023


On Thu, 26 Oct 2023 12:29:44 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:

> This patch should fix the testbug where F16 conversions were expected but were not supported by the CPU. Instead of checking for AVX, I now check for `f16c` or `avx512vl`, mirroring the logic in vm_version_x86:
> https://github.com/openjdk/jdk/blob/ec1bf23d012f007c126cb472fcff146cf7f41b1a/src/hotspot/cpu/x86/vm_version_x86.hpp#L770-L772
> 
> I went with the approach of changing the logic in the IR annotation itself instead of the test requirements, as the majority of the IR tests in this file should complete correctly on other platforms. Tier 1 testing passes on my (linux x64) machine. Reviews would be appreciated!

This pull request has now been integrated.

Changeset: 2a76ad97
Author:    Jasmine Karthikeyan <jkarthikeyan at openjdk.org>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/2a76ad975c8612c19f6c1c8f5a996017f753cb66
Stats:     3 lines in 2 files changed: 1 ins; 0 del; 2 mod

8318683: compiler/c2/irTests/TestPhiDuplicatedConversion.java "Failed IR Rules (2) of Methods (2)"

Reviewed-by: thartmann, kvn

-------------

PR: https://git.openjdk.org/jdk/pull/16378


More information about the hotspot-compiler-dev mailing list