RFR: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K) [v4]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Wed Nov 1 08:08:01 UTC 2023
On Wed, 1 Nov 2023 07:40:58 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>>> Windows: ps == os::vm_page_size < alloc granularity
>>> Everyone else: ps == os::vm_page_size == alloc granularity
>>
>> For Linux using `-XX:+UseTransparentHugePages` and Windows using `-XX:+UseLargePages`, I see `ps > os::vm_page_size()` and `ps > os::vm_allocation_granularity()`.
>
> Oh right, my bad. I thought it calls the system pagesize function. Okay, then the max2 makes sense. I'd still remove the assert though.
I am fine with removing the assert.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16373#discussion_r1378498160
More information about the hotspot-compiler-dev
mailing list