RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

Hamlin Li mli at openjdk.org
Wed Nov 1 13:45:04 UTC 2023


On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> insn_options[0] is set to empty string if there is no options (NULL or empty strings).
>> Checking it for empty string should cover both cases, caller option is NULL or caller option is empty string.
>> 
>> Tested hsdis no longer gives me the warning.
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More clear

LGTM, Thanks.

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16433#pullrequestreview-1708250640


More information about the hotspot-compiler-dev mailing list