RFR: 8318959: C2: define MachNode::fill_new_machnode() statically [v2]

[Roberto Castañeda Lozano]

On Wed, 1 Nov 2023 16:22:15 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Do not return anything from 'define_cisc_version' and 'define_short_branch_methods'
>
> src/hotspot/share/adlc/output_c.cpp line 3218:
> 
>> 3216: 
>> 3217:     // Output code to convert to the short branch version, if applicable
>> 3218:     instr->define_short_branch_methods(*this, fp);
> 
> Should you update these 2 methods since their return value is not used anymore anywhere?

Good point, done, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16444#discussion_r1379697729