RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v5]

Daniel Lundén duke at openjdk.org
Thu Nov 2 10:06:07 UTC 2023


On Tue, 31 Oct 2023 16:22:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add second test case with reduced set of flags
>
> test/hotspot/jtreg/compiler/ccp/TestShiftConvertAndNotification.java line 62:
> 
>> 60:   }
>> 61:   public static void main(String[] strArr) {
>> 62:       for (int i = 0; i < 1000; i++)
> 
> Suggestion:
> 
>       for (int i = 0; i < 20_000; i++)
> 
> This would ensure that `test` is compiled even without `-Xcomp`, which may be helpful for the "vanilla" (your run with fewer flags)

Great, fixed now

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1379859629


More information about the hotspot-compiler-dev mailing list