RFR: 8316592: RISC-V: implement poly1305 intrinsic [v3]
null
duke at openjdk.org
Thu Nov 2 14:46:42 UTC 2023
On Wed, 1 Nov 2023 18:46:59 GMT, null <duke at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4498:
>>
>>> 4496:
>>> 4497: // Arguments
>>> 4498: const Register input_start = *regs, length = *++regs, acc_start = *++regs, r_start = *++regs;
>>
>> Can you add some comments before this method about?
>> 1. the corresponding java method name being intrinsified.
>> 2. the mapping between the passed-in java arguments and resgiters used to hold the parameter.
>> And seems its more clear to use specific name such as c_rarg0/1 for `arguments` instead of this iterator. (For other registers, iterator is fine).
>
> Explicitly specified argument registers. I'll do the rest a bit later.
All done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16417#discussion_r1380257210
More information about the hotspot-compiler-dev
mailing list