RFR: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask [v8]

[Daniel Lundén]

On Thu, 2 Nov 2023 16:34:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/node.hpp line 1136:
>> 
>>> 1134:   // definition of Unique_Node_List
>>> 1135:   template <typename Callback, typename Bypass>
>>> 1136:   void visit_uses(Callback callback, Bypass bypass);
>> 
>> You should say in the comment that only "boundary" nodes get a callback.
>
> `bypass` could be misunderstood as "ignoring and not recursing".
> Maybe you should say that you look through these nodes recursively, until you find a "boundary" node.
> Maybe you could even swap the logic to "is_boundary_node"?

Sure, I'll fix that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16429#discussion_r1381595247